-
Notifications
You must be signed in to change notification settings - Fork 481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SYSTEMDS-3780] Compression-fused quantization #2226
Open
anuunchin
wants to merge
7
commits into
apache:main
Choose a base branch
from
anuunchin:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+2,196
−114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Baunsgaard
reviewed
Feb 14, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lots of very good things,
I have left a few comments, And i would like to see some performance numbers.
Specifically, with the fused operator vs without.
You can run it across various sizes, or distinct values after quantization.
src/main/java/org/apache/sysds/hops/rewrite/RewriteQuantizationFusedCompression.java
Outdated
Show resolved
Hide resolved
src/main/java/org/apache/sysds/parser/BuiltinFunctionExpression.java
Outdated
Show resolved
Hide resolved
src/main/java/org/apache/sysds/runtime/compress/CompressedMatrixBlockFactory.java
Outdated
Show resolved
Hide resolved
src/main/java/org/apache/sysds/runtime/compress/CompressionSettingsBuilder.java
Show resolved
Hide resolved
src/main/java/org/apache/sysds/runtime/compress/colgroup/ColGroupFactory.java
Outdated
Show resolved
Hide resolved
src/main/java/org/apache/sysds/runtime/compress/estim/encoding/EncodingFactory.java
Outdated
Show resolved
Hide resolved
src/main/java/org/apache/sysds/runtime/compress/estim/encoding/EncodingFactory.java
Outdated
Show resolved
Hide resolved
src/main/java/org/apache/sysds/runtime/compress/estim/encoding/EncodingFactory.java
Outdated
Show resolved
Hide resolved
src/main/java/org/apache/sysds/runtime/instructions/InstructionParser.java
Outdated
Show resolved
Hide resolved
src/main/java/org/apache/sysds/runtime/instructions/InstructionParser.java
Outdated
Show resolved
Hide resolved
89b0774
to
a6ba80a
Compare
Rewrite impovement and test Rewrite test improved Added some exceptions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is part of the LDE project, addressing #3780.
What for?
To introduce a new instruction to fuse quantization and compression.
Given:
This PR adds a rewrite and instruction that replaces the sequence with a new built-in function:
quantize_compress(M, S)
Currently covered
quantize_compress()
Further