Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SYSTEMDS-3842] Improve test coverage of API components #2241

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

e-strauss
Copy link
Contributor

@e-strauss e-strauss commented Mar 5, 2025

This PR extends the test coverage of the API components: DMLScript (96%) and CLIOptions (99.7%).

Additionally, I identified an unreachable code fragment in the codegen SpoofCompiler and added a TODO for further investigation.

Other API components will be addressed in separate PRs.

@e-strauss e-strauss force-pushed the api_code_coverage branch from ba3e1a0 to bf209d3 Compare March 5, 2025 13:35
Copy link

codecov bot commented Mar 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.57%. Comparing base (cfbe190) to head (74ac36f).
Report is 6 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2241      +/-   ##
============================================
+ Coverage     72.47%   72.57%   +0.10%     
- Complexity    45466    45519      +53     
============================================
  Files          1469     1469              
  Lines        170893   170896       +3     
  Branches      33325    33325              
============================================
+ Hits         123851   124036     +185     
+ Misses        37632    37471     -161     
+ Partials       9410     9389      -21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@e-strauss e-strauss force-pushed the api_code_coverage branch 2 times, most recently from 9453a3d to f9b29d6 Compare March 7, 2025 16:47
@e-strauss e-strauss changed the title [WIP] Improved test coverage of API: DMLOptions [SYSTEMDS-3842] Improve test coverage of API components Mar 7, 2025
@e-strauss e-strauss force-pushed the api_code_coverage branch from 0e290cc to 74ac36f Compare March 8, 2025 09:25
@e-strauss e-strauss requested a review from mboehm7 March 9, 2025 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

None yet

1 participant