-
Notifications
You must be signed in to change notification settings - Fork 74
chore: get rid of now-stabilized error_in_core feature #260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
3931516 to
7139a0d
Compare
7139a0d to
ec74bef
Compare
|
pipeline fails with error: an inner attribute is not permitted in this context
--> /__w/teaclave-trustzone-sdk/teaclave-trustzone-sdk/optee-utee/target/debug/build/optee-utee-d980c343d6a5328f/out/error_in_core.rs:1:1
|
1 | #![feature = "error_in_core"]
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= note: inner attributes, like `#![no_std]`, annotate the item enclosing them, and are usually found at the beginning of source files
= note: outer attributes, like `#[test]`, annotate the item following themAnd please add a valid license header to |
optee-utee/build.rs
Outdated
| let s = if version_check::is_min_version($version).unwrap_or(false) { | ||
| String::new() | ||
| } else { | ||
| format!("#![feature = \"{}\"]\n", $feat) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be: format!("#![feature({})]\n", $feat)
| @@ -0,0 +1,27 @@ | |||
| use std::fs; | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a valid license header.
|
Unfortunately it looks like the code doesn't work how I thought it would :( |
|
Closing. I don't think there's a good solution here other than upgrading the stdlib fork and afterwards the rust-toolchain.toml. |
|
Fixed by #262 |
(continuation of #258 )
Attempting to build the SDK without stable compiler features is not possible right now due to the use of
#![feature(error_in_core)]. However, this feature was stabilized in rust 1.81 in September 2024.It would be good to remove the now-unneeded unstable flag.