doc: Remove stale notes#204
Conversation
There was a note in `TVM_FFI_DLL_EXPORT_TYPED_FUNC` saying: ``` \note ExportName and Function must be different ``` which has been stale for a while. The system doesn't have the constraint as of today. This PR removes this line.
Summary of ChangesHello @junrushao, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on improving the accuracy of the project's documentation by removing outdated information. Specifically, it addresses a note that no longer reflects the current system's behavior, ensuring that developers rely on correct and up-to-date guidance when working with the FFI. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request removes a stale documentation note from the TVM_FFI_DLL_EXPORT_TYPED_FUNC macro. The note incorrectly stated that the ExportName and Function parameters must be different. As confirmed by existing test cases, this constraint is no longer valid. The change is correct and improves the accuracy of the documentation. I have no further comments.
There was a note in
TVM_FFI_DLL_EXPORT_TYPED_FUNCsaying:which has been stale for a while. The system doesn't have the constraint as of today. This PR removes this line.