Skip to content

fix: More fix of ml_dtypes<0.5#222

Merged
tqchen merged 2 commits into
apache:mainfrom
oraluben:more-ml-types-fix
Nov 5, 2025
Merged

fix: More fix of ml_dtypes<0.5#222
tqchen merged 2 commits into
apache:mainfrom
oraluben:more-ml-types-fix

Conversation

@oraluben

@oraluben oraluben commented Nov 4, 2025

Copy link
Copy Markdown
Contributor

This is a followup of #198 of a missing fix.

@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @oraluben, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a compatibility issue with the ml_dtypes library by modifying how the float4_e2m1fn data type is registered. The change ensures that this specific data type is only added if it is available in the installed ml_dtypes version, thereby preventing runtime errors when using older versions of the library. This is a follow-up fix to a previous attempt to resolve this issue.

Highlights

  • ml_dtypes Compatibility: Introduced a conditional check to register ml_dtypes.float4_e2m1fn only if it exists, ensuring compatibility with ml_dtypes versions older than 0.5.0 and preventing attribute errors.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request aims to fix a compatibility issue with older versions of ml_dtypes by adding a hasattr check for float4_e2m1fn. The change is in the right direction, but it's incomplete and could still lead to crashes with very old ml_dtypes versions. I've suggested correcting a version number in a comment and pointed out that other recently added dtypes also need to be guarded for a complete fix.

Comment thread python/tvm_ffi/_dtype.py
@tqchen

tqchen commented Nov 4, 2025

Copy link
Copy Markdown
Member

please fix lint

@tqchen tqchen merged commit b9a2b92 into apache:main Nov 5, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants