Skip to content

[DOCS] Clarify CStrParts error handling usage#625

Merged
tqchen merged 1 commit into
apache:mainfrom
tqchen:tvm-ffi-fix-cstrparts-error-handling-docs-wording
Jun 17, 2026
Merged

[DOCS] Clarify CStrParts error handling usage#625
tqchen merged 1 commit into
apache:mainfrom
tqchen:tvm-ffi-fix-cstrparts-error-handling-docs-wording

Conversation

@tqchen

@tqchen tqchen commented Jun 17, 2026

Copy link
Copy Markdown
Member

Summary:

  • Clarify that TVMFFIErrorSetRaisedFromCStrParts is for assembling error messages from reusable parts, not for non-null-terminated strings with explicit lengths.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the documentation in docs/concepts/abi_overview.rst to clarify that TVMFFIErrorSetRaisedFromCStrParts should be used when assembling error messages from reusable parts to avoid duplicating common message fragments. There are no review comments, and we have no feedback to provide.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@tqchen tqchen merged commit 4f1cbdc into apache:main Jun 17, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants