Skip to content

[FFI] Make StructuralEqual functor compare tensor content #646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pisarev wants to merge 2 commits into
base: main
Choose a base branch
from
+41 −1
Open

[FFI] Make StructuralEqual functor compare tensor content #646

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7b831e1
[FFI] Make StructuralEqual functor compare tensor content
pisarev Jun 26, 2026
66b381b
[FFI] Add regression test for StructuralEqual tensor content
pisarev Jun 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion include/tvm/ffi/extra/structural_equal.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ class StructuralEqual {
* \return True if the two Any values are structurally equal, false otherwise.
*/
TVM_FFI_INLINE bool operator()(const Any& lhs, const Any& rhs) const {
return Equal(lhs, rhs, false, true);
return Equal(lhs, rhs, false, false);

@gemini-code-assist gemini-code-assist Bot Jun 26, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Passing multiple consecutive boolean literals (often referred to as the "Boolean Trap") reduces code readability and increases the risk of parameter mismatch errors. Since both map_free_vars and skip_tensor_content default to false in the signature of Equal, we can simplify this call to Equal(lhs, rhs) to make the code cleaner and more maintainable.

    return Equal(lhs, rhs);

}
};

Expand Down