[#1628] test(client): Fix double release ShuffleIndexResult cause exception to pass flaky test #2179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maobaolong
changed the title
|
Encountered flaky test. |
jerqi
reviewed
Oct 15, 2024
| try { | ||
| this.buffer.release(); | ||
| } catch (Throwable e) { | ||
| LOG.warn( |
There was a problem hiding this comment.
Could you log the Throwable e, too?
There was a problem hiding this comment.
You should catch specific exception class instead of Throwable.
|
@jerqi Log the e too, PTAL. |
maobaolong
force-pushed
the
fixFlakyTest
branch
from
bf7314f to
88aeb81
Compare
maobaolong
changed the title
|
@jerqi Thanks for your review! |
maobaolong
added a commit
to maobaolong/incubator-uniffle
that referenced
this pull request
Nov 4, 2024
…se exception to pass flaky test (apache#2179) ### What changes were proposed in this pull request? (Please outline the changes and how this PR fixes the issue.) ### Why are the changes needed? - Pass the flaky test - Avoid memory leak after double release the `ShuffleIndexResult` Fix: apache#1628 ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Flaky test can be fixed. (cherry picked from commit 4c14b97)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
(Please outline the changes and how this PR fixes the issue.)
Why are the changes needed?
ShuffleIndexResultFix: #1628
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Flaky test can be fixed.