Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#2383] Improvement: Fix the warning that unchecked call to RecordsReader(RssConf,SerInputStream,Class<K>,Class<V>,boolean,boolean) as a member of the raw type RecordsReader #2386

Merged
merged 3 commits into from
Mar 11, 2025

Conversation

cchung100m
Copy link
Collaborator

@cchung100m cchung100m commented Mar 9, 2025

What changes were proposed in this pull request?

Fix the warning that unchecked call to RecordsReader(RssConf,SerInputStream,Class<K>,Class<V>,boolean,boolean) as a member of the raw type RecordsReader

Why are the changes needed?

Fix: #2383

Does this PR introduce any user-facing change?

No.

How was this patch tested?

image

Copy link

github-actions bot commented Mar 9, 2025

Test Results

 2 996 files  ±0   2 996 suites  ±0   6h 32m 13s ⏱️ +46s
 1 105 tests ±0   1 103 ✅ ±0   2 💤 ±0  0 ❌ ±0 
13 849 runs  ±0  13 819 ✅ ±0  30 💤 ±0  0 ❌ ±0 

Results for commit 5d2ce4c. ± Comparison against base commit 41155a7.

♻️ This comment has been updated with latest results.

@codecov-commenter
Copy link

codecov-commenter commented Mar 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.95%. Comparing base (8ad0f8d) to head (dfb0863).
Report is 1 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2386      +/-   ##
============================================
+ Coverage     51.34%   51.95%   +0.60%     
  Complexity     3615     3615              
============================================
  Files           571      550      -21     
  Lines         32892    30339    -2553     
  Branches       2833     2833              
============================================
- Hits          16890    15764    -1126     
+ Misses        14932    13578    -1354     
+ Partials       1070      997      -73     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

…ordsReader(RssConf,SerInputStream,Class<K>,Class<V>,boolean,boolean) as a member of the raw type RecordsReader
@cchung100m cchung100m marked this pull request as ready for review March 10, 2025 13:38
@cchung100m cchung100m requested a review from jerqi March 11, 2025 02:53
Copy link
Contributor

@jerqi jerqi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@cchung100m
Copy link
Collaborator Author

Thanks to @jerqi 😸

@jerqi jerqi merged commit 86da646 into apache:master Mar 11, 2025
41 checks passed
@cchung100m cchung100m deleted the issue-2383 branch March 11, 2025 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants