Skip to content

[#2439] fix(test): remove shuffleServer from coordinators when it stops#2440

Merged
xianjingfeng merged 2 commits into
apache:masterfrom
xianjingfeng:issue_2439
Apr 11, 2025
Merged

[#2439] fix(test): remove shuffleServer from coordinators when it stops#2440
xianjingfeng merged 2 commits into
apache:masterfrom
xianjingfeng:issue_2439

Conversation

@xianjingfeng

Copy link
Copy Markdown
Member

What changes were proposed in this pull request?

Remove shuffleServer from coordinators when it stops.

Why are the changes needed?

Fix: #2439

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Repeat it for 100 times.

@github-actions

Copy link
Copy Markdown

Test Results

 3 019 files  ±0   3 019 suites  ±0   6h 44m 2s ⏱️ +12s
 1 178 tests ±0   1 177 ✅ ±0   1 💤 ±0  0 ❌ ±0 
14 922 runs  ±0  14 907 ✅ ±0  15 💤 ±0  0 ❌ ±0 

Results for commit 1fb45e3. ± Comparison against base commit 890758b.

@zuston zuston left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@xianjingfeng xianjingfeng merged commit 07eb8d5 into apache:master Apr 11, 2025
@xianjingfeng

Copy link
Copy Markdown
Member Author

@zuston Thanks for your review

@xianjingfeng xianjingfeng deleted the issue_2439 branch April 11, 2025 03:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Flaky Test] org.apache.uniffle.test.ShuffleWithRssClientTest#testRetryAssgin

2 participants