Draft PR for Jakarta ee10 jdk17 #19

eduarddrenth · 2024-07-18T19:10:05Z

For discussion on the diff, see https://issues.apache.org/jira/browse/VELTOOLS-202

pom.xml

velocity-tools-examples/velocity-tools-examples-showcase/src/main/webapp/WEB-INF/web.xml

michael-o · 2024-07-18T19:16:34Z

...s-view-jsp/src/main/java/org/apache/velocity/tools/view/jsp/jspimpl/VelocityPageContext.java

-    	// Really, who cares?
-    	throw new UnsupportedOperationException("This class works only with JSP 2.1");
-    }
-


Can you figure out frim with JSP API version this is not required anymore?

Since 4.0.0, 3.1.1 still has it. See also https://projects.eclipse.org/projects/ee4j.jsp/releases/4.0.0

Good, thanks. @arkanovicz I wonder whether we should raise to Servlet 4.0 before that.

velocity-tools-view/src/main/java/org/apache/velocity/tools/view/ServletUtils.java

velocity-tools-view/src/test/java/org/apache/velocity/tools/view/VelocityViewTest.java

constants

pom.xml

michael-o · 2024-07-19T06:35:54Z

...y-tools-view-jsp/src/main/java/org/apache/velocity/tools/view/jsp/jspimpl/JspWriterImpl.java

 import java.io.Writer;

-import javax.servlet.jsp.JspWriter;
+import jakarta.servlet.jsp.JspWriter;


Given the comments at class level, I wonder whether we still need this file...

michael-o · 2024-07-19T06:38:19Z

...s-view-jsp/src/main/java/org/apache/velocity/tools/view/jsp/jspimpl/VelocityPageContext.java

-    	// Really, who cares?
-    	throw new UnsupportedOperationException("This class works only with JSP 2.1");
-    }
-


Good, thanks. @arkanovicz I wonder whether we should raise to Servlet 4.0 before that.

michael-o · 2024-07-19T06:39:58Z

@arkanovicz I see at least two classes which have been copied from Tomcat. I wonder whether they are still required these days...

arkanovicz · 2024-07-19T07:57:03Z

@arkanovicz I see at least two classes which have been copied from Tomcat. I wonder whether they are still required these days...

I don't really maintain the jsp module. I released it unchanged last time, but if nobody can help maintain it, we can deprecate it.

michael-o · 2024-07-19T08:00:51Z

@arkanovicz I see at least two classes which have been copied from Tomcat. I wonder whether they are still required these days...

I don't really maintain the jsp module. I released it unchanged last time, but if nobody can help maintain it, we can deprecate it.

That would mean that the JSP tags are dead, aren't they?

arkanovicz · 2024-07-19T08:09:21Z

@arkanovicz I see at least two classes which have been copied from Tomcat. I wonder whether they are still required these days...

I don't really maintain the jsp module. I released it unchanged last time, but if nobody can help maintain it, we can deprecate it.

That would mean that the JSP tags are dead, aren't they?

I released it as is last time because I've been told that jsp hadn't change, so there was no real reason for the module not to be functional. But I never used jsp, never will, and I do not feel very concerned by its fate. Maybe ask the mailing list?

michael-o · 2024-07-19T08:16:10Z

@arkanovicz I see at least two classes which have been copied from Tomcat. I wonder whether they are still required these days...

I don't really maintain the jsp module. I released it unchanged last time, but if nobody can help maintain it, we can deprecate it.

That would mean that the JSP tags are dead, aren't they?

I released it as is last time because I've been told that jsp hadn't change, so there was no real reason for the module not to be functional. But I never used jsp, never will, and I do not feel very concerned by its fate. Maybe ask the mailing list?

Yes, let's do so.

pom.xml

michael-o · 2024-07-19T13:13:40Z

@eduarddrenth First of all, thank you for the good cooperation. I already see a few points I can cherry-pick and improve the current code on main, but first I need to take care of velocity master as a prep. Please stay tuned.

eduarddrenth · 2024-07-20T06:28:13Z

Thanks also, I enjoyed to play a small part in making velocity available to application servers for jakarta EE 10. I'll keep an eye open.

michael-o · 2024-07-20T06:34:26Z

Why did you close? This is viable code.

eduarddrenth · 2024-07-20T11:02:58Z

Why did you close? This is viable code.

I thought you did not need it anymore. Is the process?

prepare velocity master
merge changes into my fork
adapt or resubmit jakarta PR
merge PR
decide how to release jakarta version and release it

michael-o · 2024-07-20T11:49:52Z

Why did you close? This is viable code.

I thought you did not need it anymore. Is the process?
* prepare velocity master

* merge changes into my fork

* adapt or resubmit jakarta PR

* merge PR

* decide how to release jakarta version and release it

You misunderstood. I need to keep it open for visibile and future changes.

michael-o · 2024-11-22T14:47:12Z

Factored out a bit #21

eduarddrenth · 2024-11-22T16:16:32Z

At some point in the near future I need to decide how to include velocity deps in my jakarta apps. Either I wait for a jakarta release from the apache team, or I decide to keep my fork up-to-date and release to maven central myself. I prefer the first, but when will this release be?

michael-o · 2024-11-22T17:05:28Z

At some point in the near future I need to decide how to include velocity deps in my jakarta apps. Either I wait for a jakarta release from the apache team, or I decide to keep my fork up-to-date and release to maven central myself. I prefer the first, but when will this release be?

I have expressed my opinion in this regard in the other PR already: #15 (comment)

arkanovicz · 2025-11-03T14:22:17Z

Most of the standard containers are maintaining old versions for javax and switching to jakarta in their new versions.

I think that the easiest course of action is to do the same, because there is an underneath constraint about the target JVM version, and it will avoid us the hassle of maintaining different modules on the same sources. So my plan is:

to release a 3.2 tools version on javax
to release a 4.0 tools version on jakarta with a new velocity-master targeting the jvm 11

@michael-o , in this thread, you said:

There is another course of action, now that I think of it: maintain the tools 3.1.x on javax and switch on jakarta for 3.2+.

I am against that. Cutting off people for the years to come for a long waited update is not right. Both Jetty and Tomcat will support javax for quite some time.

But there is no reason why we cannot backport every new feature to the 3.x branch, so users wouldn't be cut off, would they?

And otherwise, I don't really know how to handle the JVM target difference.

michael-o · 2025-11-03T14:40:46Z

Most of the standard containers are maintaining old versions for javax and switching to jakarta in their new versions.

I think that the easiest course of action is to do the same, because there is an underneath constraint about the target JVM version, and it will avoid us the hassle of maintaining different modules on the same sources. So my plan is:

to release a 3.2 tools version on javax

to release a 4.0 tools version on jakarta with a new velocity-master targeting the jvm 11

@michael-o , in this thread, you said:

There is another course of action, now that I think of it: maintain the tools 3.1.x on javax and switch on jakarta for 3.2+.

I am against that. Cutting off people for the years to come for a long waited update is not right. Both Jetty and Tomcat will support javax for quite some time.

But there is no reason why we cannot backport every new feature to the 3.x branch, so users wouldn't be cut off, would they?

And otherwise, I don't really know how to handle the JVM target difference.

The proposal and discussion was to drop javax altogether which I opposed. My proposal was to support both through on the fly code rewrite if possible. Your approach with backports works as well. At the end I wanted a low effort method to serve both.

eduarddrenth added 2 commits July 18, 2024 15:56

jakarta ee 10, jdk 17 building

fdd2d47

too high version

dbf75e5

michael-o marked this pull request as draft July 18, 2024 19:14

michael-o requested changes Jul 18, 2024

View reviewed changes

too high versions

c0f7017

constants

michael-o requested changes Jul 19, 2024

View reviewed changes

eduarddrenth added 2 commits July 19, 2024 11:29

javaVersion prop

0ad18bf

lower jsp version

3e9049a

michael-o requested changes Jul 19, 2024

View reviewed changes

pom.xml Outdated Show resolved Hide resolved

11 jdk, can be run in jdk 17

d3d8a6e

eduarddrenth closed this Jul 20, 2024

michael-o reopened this Jul 20, 2024

Merge remote-tracking branch 'upstream/master' into jakartaEE10Jdk17

4121f57

Draft PR for Jakarta ee10 jdk17 #19

Are you sure you want to change the base?

Draft PR for Jakarta ee10 jdk17 #19

Uh oh!

Conversation

eduarddrenth commented Jul 18, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

michael-o Jul 18, 2024

Choose a reason for hiding this comment

Uh oh!

eduarddrenth Jul 19, 2024

Choose a reason for hiding this comment

Uh oh!

eduarddrenth Jul 19, 2024

Choose a reason for hiding this comment

Uh oh!

michael-o Jul 19, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

michael-o Jul 19, 2024

Choose a reason for hiding this comment

Uh oh!

michael-o Jul 19, 2024

Choose a reason for hiding this comment

Uh oh!

michael-o commented Jul 19, 2024

Uh oh!

arkanovicz commented Jul 19, 2024

Uh oh!

michael-o commented Jul 19, 2024

Uh oh!

arkanovicz commented Jul 19, 2024

Uh oh!

michael-o commented Jul 19, 2024

Uh oh!

Uh oh!

michael-o commented Jul 19, 2024

Uh oh!

eduarddrenth commented Jul 20, 2024

Uh oh!

michael-o commented Jul 20, 2024

Uh oh!

eduarddrenth commented Jul 20, 2024

Uh oh!

michael-o commented Jul 20, 2024

Uh oh!

michael-o commented Nov 22, 2024

Uh oh!

eduarddrenth commented Nov 22, 2024

Uh oh!

michael-o commented Nov 22, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

arkanovicz commented Nov 3, 2025

Uh oh!

michael-o commented Nov 3, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

michael-o commented Nov 22, 2024 •

edited

Loading