Feature/spark dataframes #646
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| def writeParquet(url: String, overwrite: Boolean = false)(implicit ev: Out =:= Record): Unit = | ||
| writeParquetJava(url, overwrite, preferDataset = false) | ||
|
|
||
| def writeParquetAsDataset(url: String, overwrite: Boolean = true)(implicit ev: Out =:= Record): Unit = |
Contributor
There was a problem hiding this comment.
Is it nicer for the API here if writeParquet gets a preferDataset parameter that is false by default?
This would allow to remove writeParquetAsDataset altogether.
| * @param projection the projection, if any | ||
| * @return [[DataQuantaBuilder]] for the file | ||
| */ | ||
| def readParquetAsDataset(url: String, projection: Array[String] = null): UnarySourceDataQuantaBuilder[UnarySourceDataQuantaBuilder[_, Record], Record] = |
Contributor
There was a problem hiding this comment.
The same thought goes for this.
We could use readParquet with the flag here as well.
| * @param projection the projection, if any | ||
| * @return [[DataQuanta]] of [[Record]]s backed by a Spark Dataset when executed on Spark | ||
| */ | ||
| def readParquetAsDataset(url: String, projection: Array[String] = null): DataQuanta[Record] = |
Contributor
There was a problem hiding this comment.
The same thought goes for this.
We could use readParquet with the flag here as well.
Member
Author
There was a problem hiding this comment.
good catch - yeah, good idea. Its a bit duplicated given some month of coding :)
…t the unified interface.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
README.md,guides/spark-datasets.md).Next steps / follow-ups
double[]/DoubleRDDs. We should extend them to useDatasetChannels once schema handling is in place.