Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the issue 412 ->Focus to glyphicon-search with necessary delay #455

Merged
merged 1 commit into from
Mar 6, 2025

Conversation

Imvedansh
Copy link
Contributor

@Imvedansh Imvedansh commented Mar 6, 2025

Issue -> #412
Status -> Fixed , tested on local system
Follow ups -> #429 @sebbASF
Approach(optimized) -> Added the focus to input field as soon as button is click (for rendering delay of 50ms is given as well ), Issue fixed in minimum changes
using Bootstrap's native event system to detect when the search dropdown opens and then automatically places the cursor in the search field.

Proposed Issue -> When you want to search for something, you need to type a search text string. The search text needs to be entered in the search box that opens below the search button. But the cursor is still hovering over the search button so you cannot type into the search box.
Proposed Fix -> By clicking the search icon ,input fields auto focused .

Screen.Recording.2025-03-06.at.7.31.30.AM.mov

@Imvedansh Imvedansh changed the title Fixed the issue 412 ->Focus to glyphicon-search with necesaary delay Fixed the issue 412 ->Focus to glyphicon-search with necessary delay Mar 6, 2025
@Imvedansh
Copy link
Contributor Author

@clr-apache This solves the issue in #412 ,did it with minimum changes possible

@sebbASF sebbASF merged commit b4f9cd2 into apache:preview/issue412 Mar 6, 2025
@Imvedansh
Copy link
Contributor Author

@sebbASF is it ready to be Merged into Main, or does need any further changes
Staged -> https://www-issue412.staged.apache.org/

@sebbASF
Copy link
Contributor

sebbASF commented Mar 6, 2025

Works well for me:

https://www-issue412.staged.apache.org/

@Imvedansh
Copy link
Contributor Author

@sebbASF Great!!, should PR to merge into main then?

@bproffitt
Copy link
Contributor

@sebbASF @Imvedansh Please stop merging changes to www-site without my approval. This was a good change, but I have to weigh such changes with the eventual site upstate once a new logo is created.

bproffitt pushed a commit that referenced this pull request Mar 6, 2025
@raboof
Copy link
Member

raboof commented Mar 6, 2025

Please stop merging changes to www-site without my approval. This was a good change, but I have to weigh such changes with the eventual site upstate once a new logo is created.

Do we have this rule documented somewhere? Perhaps we should add it to the README or add a CONTRIBUTING.md?

@bproffitt
Copy link
Contributor

Good idea.

@raboof
Copy link
Member

raboof commented Mar 6, 2025

Good idea.

will you or shall I propose something?

@Imvedansh
Copy link
Contributor Author

@bproffitt No direct commits were made to main branch, tested on Preview branches for reviews and feedback then later on
PR to main for your approval and feedback.
When will the release of new logo approximately?, so i can actively contribute ?.
I also believe this should be added in Readme as well, so these conflicts could be avoided in the near future
Thank you for the heads up!

@bproffitt
Copy link
Contributor

Good idea.

will you or shall I propose something?

I already added something to the README file

@raboof
Copy link
Member

raboof commented Mar 6, 2025

Good idea.

will you or shall I propose something?

I already added something to the README file

Ah, great! Do you really think every change should have an issue? For smaller changes 'just' a Pull Request might be sufficient?

@sebbASF
Copy link
Contributor

sebbASF commented Mar 6, 2025

@sebbASF @Imvedansh Please stop merging changes to www-site without my approval. This was a good change, but I have to weigh such changes with the eventual site upstate once a new logo is created.

I did not merge this change to the main site; all the activity took place in a preview branch, which was then used to create the PR #456. Which was not merged by me.

I do not make any changes directly to the main branch, except for the occasional typo.
[Though I did make a correction to the README, which does not form part of the website.]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants