FOP-2469: Auto table layout #95
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chkpnt
commented
Oct 23, 2025
chkpnt
commented
Oct 23, 2025
| */ | ||
| protected int getLineWidth(int line) { | ||
| assert lineWidth >= 0; | ||
| // assert lineWidth >= 0; |
Author
chkpnt
commented
Oct 30, 2025
| private int increaseMinimumWidthOfSpannedColumns(List columnsToWiden, int minSpanWidthOfSpannedCells, int minIPD, LayoutContext context) { | ||
| int totalIncrease = 0; | ||
|
|
||
| for (Iterator iter = columnsToWiden.iterator(); iter.hasNext();) { |
|
Sorry I don't remember. Way too long ago.
…-Eric
On Thu, Oct 30, 2025 at 7:17 AM Gregor Dschung ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In fop-core/src/main/java/org/apache/fop/layoutmgr/BreakingAlgorithm.java
<#95 (comment)>
:
> @@ -1405,7 +1405,7 @@ protected KnuthNode getNode(int line) {
* @return the width/length in millipoints
*/
protected int getLineWidth(int line) {
- assert lineWidth >= 0;
+// assert lineWidth >= 0;
What could be the reason for commenting out this assertion? I've compared
the patches in FOP-2469 <https://issues.apache.org/jira/browse/FOP-2469>
and this was introduced in Eric Lim's version of the patch. @esclim
<https://github.com/esclim> Do you remember, why you did this 7 years
ago? ;-)
—
Reply to this email directly, view it on GitHub
<#95 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABIV4GQO7NLDULVOBBNEIM332HXTXAVCNFSM6AAAAACKAPUS5GVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTGNZQGM2TQMJVGU>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft for FOP-2469 by applying FOP-2469-2018-07-17.patch.