Fallback to analysing lower-cased version on state explosion #197
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
both in analysis (lt-proc -a, with or without compounding -e) and in "bilingual generation" (lt-proc -g -b). fixes #194
Member
Author
|
@ftyers @mr-martian does this look mergeable?
processing speed seems unaffected |
Member
|
LGTM. |
unhammer
added a commit
to apertium/apertium-nno-nob
that referenced
this pull request
Mar 20, 2025
cf. apertium/lttoolbox#197 unshouts, but meh
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
both in analysis (lt-proc -a, with or without compounding -e) and in "bilingual generation" (lt-proc -g -b).
fixes #194
This has zero diffs on first 100k words of my bokmål news test corpus (where the longest all-caps word is only 9 letters long, so it never really kicks in).
When I test on some wiki dumps I get good things like