T1192 : 1 line bug fix in Visualizer, and setup timer for average frame rate measurement in firmware#42
Open
eppisai wants to merge 4 commits intoapertus-open-source-cinema:devfrom
Open
T1192 : 1 line bug fix in Visualizer, and setup timer for average frame rate measurement in firmware#42eppisai wants to merge 4 commits intoapertus-open-source-cinema:devfrom
eppisai wants to merge 4 commits intoapertus-open-source-cinema:devfrom
Conversation
BAndiT1983
reviewed
Aug 26, 2021
Member
BAndiT1983
left a comment
BAndiT1983
left a comment
There was a problem hiding this comment.
Bad formatting, empty lines are missing or too many.
have added an empty line, at the start of InitTimer2 , and added a empty line before configGPIO() . Removed empty lines from int main() start and in interupt for timer2
Contributor
Author
oh..that was quick.. thank you so much, @BAndiT1983 is above okay? |
eppisai
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
hi,
this pull request is regarding code review of some small changes that i have made, so can get them merged and proceed with tasks further
changes made