[16.0][FIX] llm_ollama: ollama_models #35
Conversation
| @@ -68,18 +70,22 @@ def ollama_models(self): | |||
| for model in response.get("models", []): | |||
| # Basic model info | |||
| model_info = { | |||
| "name": model["name"], | |||
| "name": model.get("model", ""), | |||
There was a problem hiding this comment.
@CristianoMafraJunior Hi, thank you for the lovely PR. I see in Ollama's doc that there is no key for model; rather, they return name.
https://github.com/ollama/ollama/blob/main/docs/api.md#response-25
Could you briefly let us know about your findings regarding this fix with docker?
There was a problem hiding this comment.
@CristianoMafraJunior Hi, thank you for the lovely PR. I see in Ollama's doc that there is no key for
model; rather, they returnname. https://github.com/ollama/ollama/blob/main/docs/api.md#response-25Could you briefly let us know about your findings regarding this fix with docker?
@adar2378 Everything we discovered running ollama on Docker is here in the issue #33 . Unfortunately, it doesn't bring the name information, but I will investigate this further.
There was a problem hiding this comment.
@CristianoMafraJunior maybe try to get name or model or "" as failsafe?
PR discussed in Issue #33
fixing the import of ollama models
cc @ayushin @adar2378 @peterromao