fix: Allow nested denormalization when allow_extra_attributes=false #7270
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calbro7
changed the title
soyuka
reviewed
Jul 2, 2025
| { | ||
| $allowedAttributes = parent::getAllowedAttributes($classOrObject, $context, $attributesAsString); | ||
| if (\is_array($allowedAttributes) && ($context['api_denormalize'] ?? false)) { | ||
| $allowedAttributes = array_merge($allowedAttributes, ['id']); |
There was a problem hiding this comment.
what if id isn't the property/attribute used to identify a resource?
|
This looks like it breaks one of our test would you be able to identify why? Inside |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The linked issue was resolved for JSON LD format with #6451 but not for standard JSON, so this PR implements the same change in the standard ItemNormalizer.
The included test file demonstrates the expected behaviour, it should be possible to alter the Bar entity's
somePropertyvia a PATCH request to edit its parentFooobject.This test passes with the ItemNormalizer change, but fails without it due to
Extra attributes are not allowed (\"id\" is unknown)..First contribution so let me know if I've done things correctly or if I've missed anything needed for approval!