Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: langflow ai integration docs #1425

Open
wants to merge 25 commits into
base: master
Choose a base branch
from
Open

Conversation

MQ37
Copy link
Contributor

@MQ37 MQ37 commented Jan 22, 2025

Add Langflow AI integration docs

@github-actions github-actions bot added the t-ai Issues owned by the AI team. label Jan 22, 2025
@MQ37 MQ37 requested a review from jirispilka January 24, 2025 15:05
@MQ37 MQ37 marked this pull request as ready for review January 26, 2025 20:39
@MQ37 MQ37 requested a review from TC-MO as a code owner January 26, 2025 20:39
sources/platform/integrations/ai/langflow.md Outdated Show resolved Hide resolved
sources/platform/integrations/ai/langflow.md Outdated Show resolved Hide resolved
sources/platform/integrations/ai/langflow.md Outdated Show resolved Hide resolved
sources/platform/integrations/ai/langflow.md Outdated Show resolved Hide resolved
sources/platform/integrations/ai/langflow.md Outdated Show resolved Hide resolved
sources/platform/integrations/ai/langflow.md Outdated Show resolved Hide resolved
@MQ37
Copy link
Contributor Author

MQ37 commented Jan 28, 2025

@TC-MO committed your suggestions and removed the separator, thank you

Copy link
Contributor

@jirispilka jirispilka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Looks good to me, minor comments only

@TC-MO should we add it to index.mdx - or might be too crowded?

I think it would be good to have a prerequisites section:

  • langflow (cloud or local)
  • apify token
  • openai api key for the second flow

I like it but IMO it is a bit long. Please review it and perhaps shorten it if possible.
I believe some images could be skipped (if steps are obvious from UI).

I think you are using Now, we need , Now, add, Now, the output very often. The same for we need. I would add a bit more variations if possible. But I would leave this decision to @TC-MO

sources/platform/integrations/ai/langflow.md Outdated Show resolved Hide resolved
sources/platform/integrations/ai/langflow.md Outdated Show resolved Hide resolved
sources/platform/integrations/ai/langflow.md Outdated Show resolved Hide resolved
Comment on lines 55 to 56
On the Langflow welcome screen, click the **New Flow** button:
![Langflow welcome screen - New Flow](../images/langflow/new_flow.png)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MQ37 I would limit the images so that the guide is not too long.
For example, the very first image On the Langflow welcome screen, click the New Flow button: isn't this obvious when you open langflow

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You would think so... but sometimes is not :D I would err on the side of having more thorough screenshots

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wanted the guide to be as detailed as possible - sure we can remove screens for these obvious steps

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can remove the New Flow button screen, but definitely keep the Blank Flow, I haven't noticed the button at first when using Langflow.

sources/platform/integrations/ai/langflow.md Outdated Show resolved Hide resolved
sources/platform/integrations/ai/langflow.md Outdated Show resolved Hide resolved
sources/platform/integrations/ai/langflow.md Outdated Show resolved Hide resolved
@TC-MO
Copy link
Contributor

TC-MO commented Jan 29, 2025

Thank you! Looks good to me, minor comments only

@TC-MO should we add it to index.mdx - or might be too crowded?

I think it would be good to have a prerequisites section:

* langflow (cloud or local)

* apify token

* openai api key for the second flow

I like it but IMO it is a bit long. Please review it and perhaps shorten it if possible. I believe some images could be skipped (if steps are obvious from UI).

I think you are using Now, we need , Now, add, Now, the output very often. The same for we need. I would add a bit more variations if possible. But I would leave this decision to @TC-MO

We should add it to index, the idea is after all to have the ability to nav to each guide as well as easily showcase all the guide ( apart through sidebar)

Good idea with prerequisites

The Now thing I leave up to preference, on one hand it would clear up the text, on the other this gives it a slight human touch ¯_(ツ)_/¯
Let me do another read to figure it out

@MQ37
Copy link
Contributor Author

MQ37 commented Jan 29, 2025

Thank you! Looks good to me, minor comments only

@TC-MO should we add it to index.mdx - or might be too crowded?

I think it would be good to have a prerequisites section:

* langflow (cloud or local)

* apify token

* openai api key for the second flow

I like it but IMO it is a bit long. Please review it and perhaps shorten it if possible. I believe some images could be skipped (if steps are obvious from UI).

I think you are using Now, we need , Now, add, Now, the output very often. The same for we need. I would add a bit more variations if possible. But I would leave this decision to @TC-MO

Created the prerequisites section and shortened/simplified.

@MQ37 MQ37 requested a review from jirispilka January 29, 2025 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t-ai Issues owned by the AI team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants