fix: Update maxItems and maxTotalChargeUsd desc #2088
Conversation
|
Preview for this PR was built for commit |
|
While you're at it, could you please also add |
stetizu1
left a comment
stetizu1
left a comment
There was a problem hiding this comment.
We probably can't do anything about it now, but yes, it goes against our "unify pricing" initiative when we "name" the pricing models and then somehow hide it in the UI 😅
apify-api/openapi/paths/actor-tasks/actor-tasks@{actorTaskId}@run-sync-get-dataset-items.yaml
Outdated
Show resolved
Hide resolved
|
Preview for this PR was built for commit |
|
Preview for this PR was built for commit |
| - maxItems | ||
| - maxTotalChargeUsd |
There was a problem hiding this comment.
Are these actually required?
| results that will be charged to your subscription. You can access the | ||
| maximum number of items in your Actor by using the | ||
| `ACTOR_MAX_PAID_DATASET_ITEMS` environment variable. | ||
| Specifies the maximum number of dataset items that will be charged for pay-per-result Actors. |
There was a problem hiding this comment.
I see quite a bit of repetition here - could you make some reusable parameter objects and reference them in the relevant endpoints? See https://swagger.io/specification/#components-object
|
Preview for this PR was built for commit |
| of results that will be charged to your subscription. You can access the | ||
| maximum number of items in your Actor by using the | ||
| `ACTOR_MAX_PAID_DATASET_ITEMS` environment variable. | ||
| Specifies the maximum number of dataset items that will be charged for pay-per-result Actors. |
There was a problem hiding this comment.
I'm too lazy to check it myself, is there a reason not to use the reusable parameter here as well?
|
Preview for this PR was built for commit |
Note
Clarifies OpenAPI docs for
maxItems(pay-per-result charge cap) andmaxTotalChargeUsd(pay-per-event cost cap) across actor and task run endpoints, including env var references.maxItemsquery param description inactors/*run-sync*.yamlandactor-tasks/*run-sync*.yaml:ACTOR_MAX_PAID_DATASET_ITEMS.maxTotalChargeUsdquery param description inactors/*runs*.yaml,actors/*run-sync*.yaml, andactor-tasks/*runs*.yaml:ACTOR_MAX_TOTAL_CHARGE_USD.Written by Cursor Bugbot for commit 99fc4f1. Configure here.