feat: Add specialized ApifyRequestQueueClientSimple
#573
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
t-tooling
Migrate most actor based tests to normal force cloud rq tests (for future parametrization of the Apify clients)
Pijukatel
changed the title
ApifyRequestQueueClientSimple
github-actions
bot
added
the
tested
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Create two variants of the
ApifyRequestQueueClient:ApifyRequestQueueClientFull- current version that supports multiple producers/consumers and locking of requests. More Apify API calls, more expensive, slightly higher network load.ApifyRequestQueueClientSimple- new constrained client for self-consumer and multiple constrained producers. (Detailed constraints in the docs). Fewer Apify API calls, cheaper, slightly lower network load.Most of the
ApifyRequestQueueClienttests were moved away from actor-based tests, so that they can be parametrized for both versions of theApifyRequestQueueClientsand to make local debugging easier.TODO: Agree with the team on how the specialized Queues will be constructed from the user perspective. The default will be the one without locks - already included in the PR.
Issues