Skip to content

Add support for AdonisJS #83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Mar 24, 2025
Merged

Add support for AdonisJS #83

merged 13 commits into from
Mar 24, 2025

Conversation

itssimon
Copy link
Member

No description provided.

@itssimon itssimon self-assigned this Mar 21, 2025
Copy link

codecov bot commented Mar 21, 2025

Codecov Report

Attention: Patch coverage is 92.14286% with 22 lines in your changes missing coverage. Please review.

Project coverage is 91.67%. Comparing base (6779c71) to head (8b0331b).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/adonisjs/middleware.ts 91.39% 13 Missing ⚠️
src/common/utils.ts 65.00% 7 Missing ⚠️
src/adonisjs/provider.ts 97.36% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #83      +/-   ##
==========================================
+ Coverage   91.54%   91.67%   +0.13%     
==========================================
  Files          21       25       +4     
  Lines        2460     2727     +267     
  Branches      285      321      +36     
==========================================
+ Hits         2252     2500     +248     
- Misses        203      220      +17     
- Partials        5        7       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@itssimon itssimon requested a review from Copilot March 24, 2025 02:12
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for AdonisJS by introducing new middleware, provider components, and corresponding tests, as well as updating documentation and CI workflows to include AdonisJS support.

  • Introduces AdonisJS-specific middleware and provider code.
  • Adds tests and updates configuration and routing for AdonisJS.
  • Updates documentation and CI workflows to cover the new AdonisJS integration.

Reviewed Changes

Copilot reviewed 14 out of 15 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
src/adonisjs/middleware.ts New middleware implementation for logging and error handling.
tests/adonisjs/app.test.ts New test suite for middleware, provider-ready startup, and counters.
tests/adonisjs/app.ts Test application and routing setup for AdonisJS integration.
src/common/utils.ts Introduces/reexports parseContentLength function for content parsing.
src/adonisjs/provider.ts New provider for initializing ApitallyClient and collecting routes.
README.md Documentation update including AdonisJS setup instructions.
.github/workflows/tests.yaml CI workflow updated to run tests for AdonisJS.
src/common/client.ts Minor update to error message for invalid client IDs.
src/express, src/koa, src/fastify, src/hono/middleware.ts Adjustments to content length parsing and logging to ensure consistency.
Files not reviewed (1)
  • package.json: Language not supported

@itssimon itssimon merged commit b86f219 into main Mar 24, 2025
57 checks passed
@itssimon itssimon deleted the adonisjs branch March 24, 2025 02:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant