added SQLBackend commit/close methods and a TestBackendPersistence me… #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodSpeed Performance ReportMerging #51 will not alter performanceComparing Summary
|
j6k4m8
reviewed
May 13, 2024
| @@ -131,6 +131,29 @@ | |||
| ), | |||
| ) | |||
|
|
|||
| # @pytest.mark.parametrize("backend", backend_test_params) | |||
| class TestBackendPersistence: | |||
|
Thank you @acthecoder23!! And +1 for the tests too! :) |
|
Just added this to v0.5.1 on PyPI! |
|
Thank you @j6k4m8 ! I wasn't sure the details of the benchmarking decorator in the tests hence leaving it as a comment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added commit and close methods to SQLBackend, as well as a test for persistence. The new test passes, as do the rest of the tests in test_backends.py, after adding the change.