Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: compatible with snakeyaml-2.0 #34

Closed

Conversation

richieyan
Copy link
Contributor

@richieyan richieyan commented Aug 21, 2023

What's the purpose of this PR

since snakeyaml-2.0 has remove empty args constructor, we need use the constructor with options

Which issue(s) this PR fixes:

Fixes # apolloconfig/apollo#4960

Brief changelog

-    return new Yaml(new SafeConstructor(), new Representer(), new DumperOptions(), loadingConfig);
+   DumperOptions dumperOptions = new DumperOptions();
+   return new Yaml(new SafeConstructor(loadingConfig),
            new Representer(dumperOptions), dumperOptions, loadingConfig);

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Read the Contributing Guide before making this pull request.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit tests to verify the code.
  • Run mvn clean test to make sure this pull request doesn't break anything.
  • Update the CHANGES log.

@github-actions
Copy link

CLA Assistant Lite bot:
Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


yanzhuzhu seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You can retrigger this bot by commenting recheck in this Pull Request

@richieyan richieyan closed this Aug 21, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Aug 21, 2023
@richieyan richieyan deleted the compatible-with-snakeyaml-2.0 branch August 21, 2023 10:28
@richieyan richieyan restored the compatible-with-snakeyaml-2.0 branch August 21, 2023 10:29
@richieyan richieyan deleted the compatible-with-snakeyaml-2.0 branch August 21, 2023 10:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant