Pagination: only replace existing edges when an incoming page has no before or after argument #278
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fter argument. Ignore incoming pages we don't know how to merge.
rohandhruva
reviewed
Dec 4, 2025
| mergedHasPreviousPage = incomingHasPreviousPage | ||
| mergedHasNextPage = incomingHasNextPage | ||
| // We can't do anything with that page: ignore it | ||
| return existing |
Contributor
There was a problem hiding this comment.
Should we log to the apollo exception handler here to make it easier to catch when this happens?
Collaborator
Author
There was a problem hiding this comment.
Yes I think it doesn't hurt (except if we want to add a dedicated exception, which would increase the API surface, which I'm not too keen on doing - but just a generic Exception with a good message is probably OK?)
Contributor
There was a problem hiding this comment.
That sounds ok, or we can also provide an optional lambda that is called when this happens, so the user can decide. But that also increases the api surface 😬
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ignore incoming pages we don't know how to merge.
Fix for #275