Skip to content

Allow empty deprecation messages #6779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 6, 2025
+55 −20
Merged

Allow empty deprecation messages #6779

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8e12d64
Allow empty deprecation messages
martinbonnin Nov 6, 2025
3b25590
add test
martinbonnin Nov 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions ...er/src/main/kotlin/com/apollographql/apollo/compiler/codegen/kotlin/helpers/Deprecated.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,6 @@ import com.squareup.kotlinpoet.AnnotationSpec
internal fun deprecatedAnnotation(message: String) = AnnotationSpec
.builder(KotlinSymbols.Deprecated)
.apply {
if (message.isNotBlank()) {
addMember("message = %S", message)
}
addMember("message = %S", message)
}
.build()
1 change: 1 addition & 0 deletions libraries/apollo-compiler/src/test/graphql/com/example/deprecation/TestOperation.graphql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,5 +4,6 @@ query TestQuery($episode: Episode) {
name
deprecated
deprecatedBool
deprecatedEmptyReason
}
}
23 changes: 18 additions & 5 deletions ...t/graphql/com/example/deprecation/java/operationBased/deprecation/TestQuery.java.expected
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

11 changes: 9 additions & 2 deletions ...precation/java/operationBased/deprecation/adapter/TestQuery_ResponseAdapter.java.expected
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 2 additions & 1 deletion .../deprecation/java/operationBased/deprecation/selections/TestQuerySelections.java.expected
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 5 additions & 2 deletions ...st/graphql/com/example/deprecation/kotlin/responseBased/deprecation/TestQuery.kt.expected
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

11 changes: 9 additions & 2 deletions ...eprecation/kotlin/responseBased/deprecation/adapter/TestQuery_ResponseAdapter.kt.expected
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 4 additions & 0 deletions ...e/deprecation/kotlin/responseBased/deprecation/selections/TestQuerySelections.kt.expected
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions libraries/apollo-compiler/src/test/graphql/com/example/deprecation/schema.graphqls
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,4 +10,5 @@ type Character {
name: String!
deprecated: String! @deprecated
deprecatedBool: Boolean! @deprecated
deprecatedEmptyReason: String! @deprecated(reason: "")
}
10 changes: 5 additions & 5 deletions libraries/apollo-compiler/src/test/graphql/com/example/measurements
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,11 @@
// If you updated the codegen and test fixtures, you should commit this file too.

Test: Total LOC:
aggregate-all 200014
aggregate-kotlin-responseBased 62779
aggregate-all 200049
aggregate-kotlin-responseBased 62793
aggregate-kotlin-operationBased 41065
aggregate-kotlin-compat 0
aggregate-java-operationBased 96170
aggregate-java-operationBased 96191

java-operationBased-fragments_with_defer_and_include_directives 5747
kotlin-operationBased-fragments_with_defer_and_include_directives 3409
Expand Down Expand Up @@ -133,13 +133,13 @@ kotlin-operationBased-fragment_spread_with_nested_fields
java-operationBased-monomorphic 648
java-operationBased-interface_always_nested 644
kotlin-responseBased-union_fragment 641
java-operationBased-deprecation 639
kotlin-responseBased-used_arguments 639
java-operationBased-capitalized_fields 626
java-operationBased-field_with_include_directive 625
java-operationBased-hero_with_review 625
kotlin-operationBased-operationbased2_ex8 625
java-operationBased-recursive_selection 622
java-operationBased-deprecation 618
kotlin-operationBased-union_fragment 607
kotlin-responseBased-java_android_annotations 606
kotlin-responseBased-java_apollo_optionals 606
Expand Down Expand Up @@ -205,9 +205,9 @@ kotlin-operationBased-typename_always_first
java-operationBased-merged_include 451
java-operationBased-operation_id_generator 451
kotlin-operationBased-path_vs_flat_accessors 448
kotlin-responseBased-deprecation 444
kotlin-responseBased-hero_name 441
kotlin-responseBased-interface_always_nested 432
kotlin-responseBased-deprecation 430
kotlin-responseBased-enum_field 430
kotlin-operationBased-root_query_fragment 424
kotlin-responseBased-inline_fragment_for_non_optional_field 423
Expand Down
Loading