Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add missing slash in the config path #7072

Merged
merged 1 commit into from
Mar 27, 2025
Merged

docs: add missing slash in the config path #7072

merged 1 commit into from
Mar 27, 2025

Conversation

DaleSeo
Copy link
Contributor

@DaleSeo DaleSeo commented Mar 21, 2025 •
edited by goto-bus-stop
Loading

Noticed / is missing in the config path

Closes #6107

Checklist

Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.

  • Changes are compatible1
  • Documentation2 completed
  • Performance impact assessed and acceptable
  • Tests added and passing3
    • Unit Tests
    • Integration Tests
    • Manual Tests

Exceptions

Note any exceptions here

Notes

Footnotes

  1. It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this. ↩

  2. Configuration is an important part of many changes. Where applicable please try to document configuration examples. ↩

  3. Tick whichever testing boxes are applicable. If you are adding Manual Tests, please document the manual testing (extensively) in the Exceptions. ↩

@DaleSeo DaleSeo added the documentation Improvements or additions to documentation label Mar 21, 2025
@DaleSeo DaleSeo self-assigned this Mar 21, 2025
@DaleSeo DaleSeo requested a review from a team as a code owner March 21, 2025 17:06
@github-actions GitHub Actions
Copy link
Contributor

@DaleSeo, please consider creating a changeset entry in /.changesets/. These instructions describe the process and tooling.

@svc-apollo-docs
Copy link
Collaborator

svc-apollo-docs commented Mar 21, 2025 •
edited
Loading

✅ Docs preview ready

The preview is ready to be viewed. View the preview

File Changes

0 new, 1 changed, 0 removed 
* graphos/routing/(latest)/self-hosted/containerization/index.mdx

Build ID: d17e7df7ee01c8fcdd84a5ca

URL: https://www.apollographql.com/docs/deploy-preview/d17e7df7ee01c8fcdd84a5ca

shorgi
shorgi approved these changes Mar 21, 2025
View reviewed changes
Copy link
Contributor

@shorgi shorgi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @DaleSeo !

@shorgi shorgi added the backport-1.x Backport this PR to 1.x label Mar 21, 2025
@shorgi
Copy link
Contributor

shorgi commented Mar 21, 2025

@mergify queue

@mergify Mergify
Copy link
Contributor

mergify bot commented Mar 21, 2025 •
edited
Loading

queue

🛑 The pull request has been removed from the queue default

The following conditions don't match anymore:

  • any of: [📌 queue requirement]
    • check-neutral = Mergify Merge Protections
    • check-skipped = Mergify Merge Protections
    • check-success = Mergify Merge Protections
  • any of: [🔀 queue conditions]
    • all of: [📌 queue conditions of queue default]
      • any of: [🛡 GitHub repository ruleset rule]
        • check-neutral = CLA
        • check-skipped = CLA
        • check-success = CLA
      • any of: [🛡 GitHub repository ruleset rule]
        • check-neutral = ci/circleci: test-amd_linux_test
        • check-skipped = ci/circleci: test-amd_linux_test
        • check-success = ci/circleci: test-amd_linux_test
      • any of: [🛡 GitHub repository ruleset rule]
        • check-neutral = ci/circleci: test-arm_linux_test
        • check-skipped = ci/circleci: test-arm_linux_test
        • check-success = ci/circleci: test-arm_linux_test
      • any of: [🛡 GitHub repository ruleset rule]
        • check-neutral = ci/circleci: test-macos_test
        • check-skipped = ci/circleci: test-macos_test
        • check-success = ci/circleci: test-macos_test
      • any of: [🛡 GitHub repository ruleset rule]
        • check-neutral = ci/circleci: test-windows_test
        • check-skipped = ci/circleci: test-windows_test
        • check-success = ci/circleci: test-windows_test
      • any of: [🛡 GitHub repository ruleset rule]
        • check-neutral = Mergify Merge Protections
        • check-skipped = Mergify Merge Protections
        • check-success = Mergify Merge Protections

@mergify Mergify
Copy link
Contributor

mergify bot commented Mar 21, 2025

This pull request has been removed from the queue for the following reason: checks failed.

The merge conditions cannot be satisfied due to failing checks

You may have to fix your CI before adding the pull request to the queue again.

If you want to requeue this pull request, you can post a @mergifyio requeue comment.

@shorgi
Copy link
Contributor

shorgi commented Mar 21, 2025

@DaleSeo - the mergify merge failed the CLA check. From reading this thread, maybe it'll be resolved if you sign in first? (cc @BrynCooke)

@goto-bus-stop
Copy link
Member

That Slack thread is just for PRs opened by Mergify. I think @DaleSeo just needs to sign the CLA here: https://contribute.apollographql.com/

@goto-bus-stop goto-bus-stop enabled auto-merge (squash) March 24, 2025 08:23
@DaleSeo
Copy link
Contributor Author

DaleSeo commented Mar 27, 2025

Thanks @shorgi @goto-bus-stop, I singed the CLA though I haven't received an email confirmation of the agreement yet.

@DaleSeo
Copy link
Contributor Author

DaleSeo commented Mar 27, 2025

@Mergifyio requeue

@mergify Mergify
Copy link
Contributor

mergify bot commented Mar 27, 2025

requeue

✅ This pull request will be re-embarked automatically

The followup queue command will be automatically executed to re-embark the pull request

@mergify Mergify
Copy link
Contributor

mergify bot commented Mar 27, 2025 •
edited
Loading

queue

🟠 Waiting for conditions to match

  • -closed [📌 queue requirement]
  • -conflict [📌 queue requirement]
  • -draft [📌 queue requirement]
  • any of: [📌 queue -> configuration change requirements]
    • -mergify-configuration-changed
    • check-success = Configuration changed
  • any of: [📌 queue requirement]
    • check-neutral = Mergify Merge Protections
    • check-skipped = Mergify Merge Protections
    • check-success = Mergify Merge Protections
  • any of: [🔀 queue conditions]
    • all of: [📌 queue conditions of queue default]
      • #approved-reviews-by >= 1 [🛡 GitHub repository ruleset rule]
      • #changes-requested-reviews-by = 0 [🛡 GitHub repository ruleset rule]
      • any of: [🛡 GitHub repository ruleset rule]
        • check-success = CLA
        • check-neutral = CLA
        • check-skipped = CLA
      • any of: [🛡 GitHub repository ruleset rule]
        • check-success = ci/circleci: check_compliance-amd_linux_build
        • check-neutral = ci/circleci: check_compliance-amd_linux_build
        • check-skipped = ci/circleci: check_compliance-amd_linux_build
      • any of: [🛡 GitHub repository ruleset rule]
        • check-success = ci/circleci: check_helm-amd_linux_helm
        • check-neutral = ci/circleci: check_helm-amd_linux_helm
        • check-skipped = ci/circleci: check_helm-amd_linux_helm
      • any of: [🛡 GitHub repository ruleset rule]
        • check-success = ci/circleci: test-amd_linux_test
        • check-neutral = ci/circleci: test-amd_linux_test
        • check-skipped = ci/circleci: test-amd_linux_test
      • any of: [🛡 GitHub repository ruleset rule]
        • check-success = ci/circleci: test-arm_linux_test
        • check-neutral = ci/circleci: test-arm_linux_test
        • check-skipped = ci/circleci: test-arm_linux_test
      • any of: [🛡 GitHub repository ruleset rule]
        • check-success = ci/circleci: test-macos_test
        • check-neutral = ci/circleci: test-macos_test
        • check-skipped = ci/circleci: test-macos_test
      • any of: [🛡 GitHub repository ruleset rule]
        • check-success = ci/circleci: test-windows_test
        • check-neutral = ci/circleci: test-windows_test
        • check-skipped = ci/circleci: test-windows_test
      • any of: [🛡 GitHub repository ruleset rule]
        • check-neutral = Mergify Merge Protections
        • check-skipped = Mergify Merge Protections
        • check-success = Mergify Merge Protections

@DaleSeo
Copy link
Contributor Author

DaleSeo commented Mar 27, 2025

@goto-bus-stop I've received the email confirmation of the agreement and commented @Mergifyio requeue, but the CLA job still failing on this PR 😞

@goto-bus-stop
Copy link
Member

Oh, it's because mergify is now the last committer on the branch, and mergify hasn't signed the CLA 😅

I'll rebase and force-push and then it should work.

@goto-bus-stop goto-bus-stop merged commit dd63df5 into dev Mar 27, 2025
15 checks passed
@goto-bus-stop goto-bus-stop deleted the DaleSeo-patch-1 branch March 27, 2025 15:49
DaleSeo added a commit that referenced this pull request Mar 27, 2025
@DaleSeo
docs: add missing slash in the config path (#7072)
aa0a6a1 
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
(cherry picked from commit dd63df5)
@DaleSeo DaleSeo mentioned this pull request Mar 27, 2025
Merged
6 tasks
goto-bus-stop pushed a commit that referenced this pull request Mar 28, 2025
@DaleSeo
docs: add missing slash in the config path (backport #7072) (#7133)
6992742
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shorgi shorgi shorgi approved these changes

Assignees

@DaleSeo DaleSeo

Labels
backport-1.x Backport this PR to 1.x documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@DaleSeo @svc-apollo-docs @shorgi @goto-bus-stop