Skip to content

Patch to make GetConfigurationValues tolerant of values provided by third party vendors that don't have an Id or Url associated with them #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gmcelhanon wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Patch to make GetConfigurationValues tolerant of values provided by third party vendors that don't have an Id or Url associated with them #5

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions AppHarbor.Net/AppHarborApi.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,20 +108,20 @@ internal AppHarborApi(AuthInfo authInfo, RestClient restClient)

private static long ExtractLongID(string url)
{
if (url == null)
throw new ArgumentNullException("url");
if (url == null)
return 0L;

return Convert.ToInt64(ExtractID(url));
}

private static string ExtractID(string url)
{
if (url == null)
throw new ArgumentNullException("url");
{
if (url == null)
return string.Empty;

return url.Split('/').Last();
}

}
private T ExecuteGet<T>(RestRequest request)
where T : new()
{
Expand Down