fix: Fix compatibility with latest Selenium snapshots #2249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
valfirst
requested review from
mykola-mokhnach,
SrinivasanTarget and
saikrishna321
as code owners
mykola-mokhnach
approved these changes
Dec 11, 2024
saikrishna321
approved these changes
Dec 11, 2024
valfirst
commented
Dec 12, 2024
valfirst
force-pushed
the
fix-compatibility-with-latest-selenium-snapshots
branch
from
0dae8da to
0ee114b
Compare
| @@ -133,7 +133,7 @@ protected void setPrivateFieldValue( | |||
| ReflectionHelpers.setPrivateFieldValue(cls, this, fieldName, newValue); | |||
| } | |||
|
|
|||
| protected Map<String, CommandInfo> getAdditionalCommands() { | |||
| public Map<String, CommandInfo> getAdditionalCommands() { | |||
There was a problem hiding this comment.
I assume there we can safely delete this getter as it is public now in the parent class
There was a problem hiding this comment.
yes, we can, but it will bump the minimal Selenium client version to 4.28.0-SNAPSHOT, if it's ok, I'll do it
There was a problem hiding this comment.
lets wait until 4.28 is released, so then we could also release a new minor version of java client and set the minimum version there
valfirst
force-pushed
the
fix-compatibility-with-latest-selenium-snapshots
branch
from
0ee114b to
713ea7c
Compare
| @@ -192,7 +192,11 @@ private Response createSession(Command command) throws IOException { | |||
| } | |||
|
|
|||
| public void refreshAdditionalCommands() { | |||
There was a problem hiding this comment.
if this method is not used anymore then it would probably make sense to mark it deprecated
valfirst
deleted the
fix-compatibility-with-latest-selenium-snapshots
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change list
Fix compatibility with latest Selenium snapshots.
Types of changes
What types of changes are you proposing/introducing to Java client?
Details
Recently Selenium team has introduced an update for Appium client adding ability to get
additionalCommandsinHttpCommandExecutor: SeleniumHQ/selenium@59aa1a0.But since new method is
publicand the same Appium method inAppiumCommandExecutor.javaisprotected, this collision introduces an error at the build stage: