Update JWS signature creators to be Sendable #111
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebastianmarr
commented
Dec 8, 2025
| private let keyId: String | ||
| private let issuerId: String | ||
| private let bundleId: String | ||
| fileprivate struct JWSSignatureCreator: Sendable { |
Author
There was a problem hiding this comment.
Changed visibility to fileprivate as the base class seemed not to be intended to be used directly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since most other components have been updated to be
Sendableand thread-safe already, I noticed the JWS signature creators were still missing. Since they are immutable already, there is no reason to not let them conform toSendable.As they were using classes, they needed to be converted into structs and use composition instead of inheritance for shared behavior. This keeps the API stable.