Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove nodeSelector provisioner-nodepool #620

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

remove nodeSelector provisioner-nodepool #620

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 0 additions & 14 deletions axlearn/cloud/gcp/job.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -538,20 +538,6 @@ def _build_pod(self) -> Nested[Any]:
PRE_PROVISIONER_LABEL: cfg.name,
}
)
else:
# Used by GCP auto-provisioner.
selector.update(
{
# NOTE: This is an arbitrary key, with a value that must be unique to the
# jobset. This forces the jobset to be associated with its own node pool;
# without this, the TPU provisioner may create a node pool and the scheduler may
# schedule a different jobset onto the node pool, which can cause conflicts if
# the original jobset attempts to restart (node pool conflict). This is more
# reliable at the moment but doesn't take advantage of node pool sharing. GCP is
# working on a fix.
"provisioner-nodepool-id": cfg.name,
}
)

annotations.update(
{
Expand Down