Prevent recursion attacks in EXT4Formatter.unlink #415
+271
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wlan0
force-pushed
the
main
branch
2 times, most recently
from
5dacd46 to
3d2676c
Compare
| var cmsgBuf = [UInt8](repeating: 0, count: Int(CZ_CMSG_SPACE(Int(MemoryLayout<Int32>.size)))) | ||
| msg.msg_control = withUnsafeMutablePointer(to: &cmsgBuf[0]) { UnsafeMutableRawPointer($0) } | ||
| msg.msg_controllen = socklen_t(cmsgBuf.count) | ||
| msg.msg_controllen = numericCast(cmsgBuf.count) |
Contributor
There was a problem hiding this comment.
What is this change for? Looks to be causing a merge conflict as well.
Contributor
Author
There was a problem hiding this comment.
numericCast takes care of converting cmsgBuf.count (Int) to whatever type is expected by the platform
msg.msg_controllen is
socklen_ton macOSsize_ton Linux
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This issue doesn't affect any of our existing products. This is a preemptive fix for downstream consumers of EXT4.format where, in some platforms, leading
//in the path could get resolved into a FileTree that looks like this