Support single file mount #425
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Create 'virtiofs' directory under container root and hardlink all mount requested files to that directory. Then, feed that directory to Linux VM through VirtIO device.
Mount shared file directory under bundlePath, and mount each file under shared file directory to corresponding target path again.
Avoid conflict from same file name.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses #79 (Single file mount support).
It creates a temporary directory, and hardlink every mount requested file to that directory.
Then, it passthrough the directory (i.e., virtiofs) and bind mount the files under target paths.
Two points to clarify:
rootfsas it usesself.target.vmexecasstderrpoints/dev/null. We can fix it throughfiles.append(stderr ?? FileHandle(fileDescriptor: 2, closeOnDealloc: false))in Sources/ContainerizationOS/Command.swift.Open problem: