Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Single.concat(Publisher) behavior consistent on cancel #2383

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Commits on Sep 30, 2022

  1. Make Single.concat(Publisher) behavior consistent on cancel

    Motivation:
    
    Behavior of `Single.concat(Publisher)` is different compare to all other
    `concat` variants: `Single.concat(Completable)`,
    `Single.concat(Single)`, `Completable.concat(Completable),
    `Completable.concat(Single)`, `Completable.concat(Publisher)`,
    `Publisher.concat(Completable)`, `Publisher.concat(Single)`,
    `Publisher.concat(Publisher)`. It does not subscribe to the next source
    to propagate cancellation if `onSuccess` is delivered after `cancel`.
    
    Modifications:
    
    - Make tests for all `concat` valiants consistent in regards to
    cancellation;
    - Modify `Single.concat(Publisher)` behavior to subscribe in case
    `onSuccess` is delivered after `cancel`;
    
    Result:
    
    Behavior of `Single.concat(Publisher)` is consistent with all other
    `concat` variants.
    idelpivnitskiy committed Sep 30, 2022
    Configuration menu
    Copy the full SHA
    1c94b48 View commit details
    Browse the repository at this point in the history

Commits on Oct 3, 2022

  1. Configuration menu
    Copy the full SHA
    6bee12f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    4a5a7e0 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    3eed6c7 View commit details
    Browse the repository at this point in the history