concurrent-api: defer logging during CapturedContextProviders initialization #3202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ization Motivation: The MDC utilities depend on the AsyncContext for storing properties. This can create a cyclical dependency since we try to log the loaded providers as part of the initialization. Modifications: Submit the logging to a different thread so that it will happen 'later' after the class initialization is complete.
...alk-concurrent-api/src/main/java/io/servicetalk/concurrent/api/CapturedContextProviders.java
Show resolved
Hide resolved
...alk-concurrent-api/src/main/java/io/servicetalk/concurrent/api/CapturedContextProviders.java
Outdated
Show resolved
Hide resolved
...alk-concurrent-api/src/main/java/io/servicetalk/concurrent/api/CapturedContextProviders.java
Show resolved
Hide resolved
bryce-anderson
force-pushed
the
bl_anderson/DontLogOnCaptureProviderInit
branch
from
58fe334 to
9e8660d
Compare
idelpivnitskiy
approved these changes
Mar 3, 2025
...-concurrent-api/src/main/java/io/servicetalk/concurrent/api/DefaultAsyncContextProvider.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
The MDC utilities depend on the AsyncContext for storing properties. This can create a cyclical dependency since we try to log the loaded providers as part of the initialization.
Modifications:
Submit the logging to a different thread so that it will happen 'later' after the class initialization is complete.