Support setting the Bonjour service TXT record. #188
+156
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: Some users may want to set or modify the advertised TXT record when publishing a Bonjour service. Modifications: Expose setting the Bonjour TXT record via new channel options. An option for setting an `NWTXTRecord` was added. This object allows for easily manipulating a TXT record, but is only available starting in MacOS 10.15, iOS 13, tvOS 13, and WatchOS 6.0, so an additional channel option has also been added to support setting the TXT record on lower OS versions. Result: Users will be able set or modify the Bonjour service TXT record.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a
NIOTSChannelOptionto configure the Bonjour service TXT record.Motivation:
Some users may want to set or modify the advertised TXT record when publishing a Bonjour service.
Modifications:
Expose setting the Bonjour TXT record via new channel options. An option for setting an
NWTXTRecordwas added. This object allows for easily manipulating a TXT record, but is only available starting inMacOS 10.15,iOS 13,tvOS 13, andWatchOS 6.0, so an additional channel option has also been added to support setting the TXT record on lower OS versions.Result:
Nothing will change for existing users, but this change allows users to be able set or modify the Bonjour service TXT record.