Add helpers for working with loop bound values #3215
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: Isolating state to a given event loop is quite a common pattern. These types often provide sendable view APIs which do the event-loop dance for you. Writing these wrappers is somewhat repetitive (each method needs to do the dance) and requires a precondition. We can make this simpler by providing helper methods on the loop bound types which do the event-loop dance. Modifications: Add three methods to NIOLoopBound and NIOLoopBoundBox: 1. `execute` to execute a task with the loop bound value on the event loop 2. `submit` to execute a task with the loop bound value on the event loop which returns a sendable value 3. `flatSubmit` to execute a task with the loop bound value on the event loop which returns a future holding a sendable value Result: Easier to build sendable views of non-sendable types which are isolated to a given event loop.
hamzahrmalik
approved these changes
May 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Isolating state to a given event loop is quite a common pattern. These types often provide sendable view APIs which do the event-loop dance for you. Writing these wrappers is somewhat repetitive (each method needs to do the dance) and requires a precondition.
We can make this simpler by providing helper methods on the loop bound types which do the event-loop dance.
Modifications:
Add three methods to NIOLoopBound and NIOLoopBoundBox:
executeto execute a task with the loop bound value on the event loopsubmitto execute a task with the loop bound value on the event loop which returns a sendable valueflatSubmitto execute a task with the loop bound value on the event loop which returns a future holding a sendable valueResult:
Easier to build sendable views of non-sendable types which are isolated to a given event loop.