Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Renaming changes #41

Merged
merged 6 commits into from
Mar 6, 2020
Merged

Renaming changes #41

merged 6 commits into from
Mar 6, 2020

Conversation

leochr
Copy link
Member

@leochr leochr commented Mar 6, 2020

What this PR does / why we need it?:

  • Rename changes (Application Stacks to Runtime Component & BaseApplication to BaseComponent
  • Update test for monitoring

Does this PR introduce a user-facing change?

  • User guide
  • CHANGELOG.md

Which issue(s) this PR fixes:

Fixes #

navidsh
navidsh approved these changes Mar 6, 2020
View reviewed changes
Copy link
Member

@navidsh navidsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thx Leo

@leochr leochr merged commit 99701d0 into master Mar 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@navidsh navidsh navidsh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@leochr @navidsh