Fixes to compile/run on aurora #264
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Documentation preview: https://applied-material-modeling.github.io/neml2/pr-preview/pr-264 |
hugary1995
requested changes
Jun 29, 2025
| set(NEML2_DOC OFF CACHE BOOL "Build NEML2 documentation (html)") | ||
| set(NEML2_WORK_DISPATCHER OFF CACHE BOOL "Enable NEML2 work dispatcher") | ||
| set(NEML2_JSON OFF CACHE BOOL "Enable JSON support") | ||
| set(AURORA_BUILD OFF CACHE BOOL "Build on ALCF Aurora machine") |
Collaborator
There was a problem hiding this comment.
I'd prefer a more general flag like NEML2_IPEX. I suppose there's nothing else specific to Aurora.
| # Intel Extension for PyTorch | ||
| # ---------------------------------------------------------------------------- | ||
| if (AURORA_BUILD) | ||
| find_library(IPEX_LIB intel-ext-pt-gpu PATHS ${INTEL_EXTENSION_FOR_PYTORCH_PATH}/lib NO_DEFAULT_PATH REQUIRED) |
Collaborator
There was a problem hiding this comment.
Suggested change
| find_library(IPEX_LIB intel-ext-pt-gpu PATHS ${INTEL_EXTENSION_FOR_PYTORCH_PATH}/lib NO_DEFAULT_PATH REQUIRED) | |
| find_library(IPEX_LIB intel-ext-pt-gpu) |
I suspect something like this will just work. You can then specify the path using -DIPEX_LIB_ROOT=....
Comment on lines
+3
to
+8
| if (AURORA_BUILD) | ||
| find_package(Threads REQUIRED) | ||
| target_link_libraries(dispatcher_tests PRIVATE testutils Threads::Threads) | ||
| else() | ||
| target_link_libraries(dispatcher_tests PRIVATE testutils) | ||
| endif() |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Miscellaneous fixes required to get things to work on aurora.