Portafino minimum req #26
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
…Address through createGianoProvider function arguments
…-sign Portafino injected flow sign
…ed_contract_addresses Extract hardcoded contract addresses
….1.0-changes Port Coinbase wallet v1.1.0 changes
Add signed_eth_call and demo call
…unt-deployed-helper Fix: missing ensureAccountDeployed(..) helper
…h usage instructions
…visibility toggle
…d can trigger Google Password Manager when using credentials.get
…te-client-server [ABI-280] Add web and node exports to Giano connector
…ion-and-retrieval Expand credential creation and retrieval
update Android test page and test results
…tcredentials-usecase
* add demo page for ROR, cross domain passkeys * improve ROR readme
- Created `deployed_addresses.json` to store addresses of deployed contracts. - Added `journal.jsonl` to log deployment and transaction details for GianoAccountFactory and GianoSmartWallet. - Introduced build info JSON file for the deployment, detailing the Solidity version and contract metadata. Co-authored-by: Steven Koch <[email protected]>
Co-authored-by: Steven Koch <[email protected]>
…rify-signature feat: Add EIP-712 message approval with signature validation to PrivateERC20 contract
…odebase. Update README to reflect the removal. (#71) Co-authored-by: Steven Koch <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces significant updates to the Giano connector, provider, and wallet integration, focusing on simplifying the codebase, improving type safety, and enhancing functionality. Key changes include renaming functions for consistency, removing unused parameters, adding event handling, and expanding the provider's capabilities.
Connector and Wallet Updates:
gianoConnectortocreateGianoConnectorfor better alignment with naming conventions and removed the unuseddetailsparameter fromCreateGianoConnectorParams. (packages/connector/src/connector.ts, [1] [2]gianowallet factory to use the renamedcreateGianoConnectorfunction and removed the dependency onWalletDetailsParams. (packages/connector/src/gianoWallet.ts, [1] [2]Provider Enhancements:
GianoProviderInjectioninterface to allow external injection of credential-related methods for better modularity. (packages/connector/src/provider.ts, packages/connector/src/provider.tsL17-R379)accountsChanged,disconnect, andchainChangedevents to improve compatibility with EIP-1193-compliant clients. (packages/connector/src/provider.ts, packages/connector/src/provider.tsL17-R379)createGianoProviderfunction to handle smart account creation, credential management, and transaction signing more robustly. (packages/connector/src/provider.ts, packages/connector/src/provider.tsL17-R379)Dependency Updates:
packages/contracts/package.jsonto use more specific version ranges for@appliedblockchain/silentdatarollup-coreand@appliedblockchain/silentdatarollup-hardhat-plugin. (packages/contracts/package.json, packages/contracts/package.jsonL26-R27)