Skip to content

Conversation

zeluisping
Copy link

@zeluisping zeluisping commented Aug 22, 2025

It's not working with the backend submission. I did not get to look into it. I believe it might be due to the lack of receipts, but that is just a guess.

This pull request introduces a new set of utilities for smart account deployment and error handling, refactors entry point definitions, and adds new provider types for custom blockchain operations. The main changes are grouped into three themes: Smart Account Deployment, Error Handling, and Provider/Entry Point Improvements.

Smart Account Deployment Utilities

  • Added ensureSmartAccountIsDeployed, isSmartAccountDeployed, and waitForSmartAccountDeployment functions to facilitate checking, deploying, and waiting for smart account deployment on-chain. These utilities are documented and exported for use throughout the codebase. [1] [2] [3] [4] [5]

Error Handling Improvements

  • Introduced a new base error class GianoError with support for error chaining and proper prototype setup, along with specialized error types for smart account deployment and timeouts. These are now exported for both Node and web environments. [1] [2] [3] [4]

Provider and Entry Point Refactoring

  • Refactored Giano entry point definitions to use explicit types and constants for ABI, address, and version, improving clarity and maintainability. [1] [2] [3] [4] [5]
  • Expanded provider custom methods and introduced generic ProviderRequestMethod typing, supporting new operations such as signed calls and user operation management. [1] [2] [3] [4]

These updates provide a more robust foundation for smart account abstraction, error management, and custom provider interactions.

@zeluisping zeluisping requested a review from jophj August 22, 2025 17:40
@zeluisping zeluisping self-assigned this Aug 22, 2025
@zeluisping zeluisping added the enhancement New feature or request label Aug 22, 2025
Copy link

coderabbitai bot commented Aug 22, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feat/sdr-chain-support

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant