Fix location dispatching

commit_hash:bc9284b4c05a93210487ea5579037d071f88b8c3
appmetrica · Dec 8, 2024 · 42b36a8 · 42b36a8
1 parent 26c7c86
commit 42b36a8
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 1 deletion.
diff --git a/AppMetricaCore/Sources/Location/AMALocationDispatcher.m b/AppMetricaCore/Sources/Location/AMALocationDispatcher.m
@@ -127,7 +127,13 @@ - (void)cancelTimer
 
 - (void)processRequest:(AMALocationRequest *)request
 {
-    AMAArrayIterator *hostsProvider = [[AMAArrayIterator alloc] initWithArray:self.configuration.hosts];
+    NSArray *hosts = self.configuration.hosts;
+    if (hosts.count == 0) {
+        AMALogError(@"Unable to retrieve host for location request");
+        return;
+    }
+
+    AMAArrayIterator *hostsProvider = [[AMAArrayIterator alloc] initWithArray:hosts];
 
     if (request == nil) {
         NSError *internalError = [AMAErrorsFactory internalInconsistencyError:@"Failed to process location request"];

diff --git a/AppMetricaCore/Tests/AMALocationDispatcherTests.m b/AppMetricaCore/Tests/AMALocationDispatcherTests.m
@@ -153,6 +153,12 @@
             [[executor should] receive:@selector(executeAfterDelay:block:)];
             [dispatcher handleVisitAdd];
         });
+
+        it(@"Should not process request if no hosts are provided", ^{
+            [configuration stub:@selector(hosts) andReturn:@[]];
+            [[requestProcessor shouldNot] receive:@selector(processWithCallback:)];
+            [dispatcher handleVisitAdd];
+        });
 
         context(@"Callback location", ^{
             beforeEach(^{