Skip to content

Commit

Permalink
fix: SSH key dropdown scrolls with modal (#38584)
Browse files Browse the repository at this point in the history
## Description

This changes the dropdown container to fix overflow issues in the Git
connect/import modal. The SSH key dropdown now properly scrolls with the
modal content instead of remaining fixed in place.

## Type of Change
- Bug fix (non-breaking change which fixes an issue)

## How Has This Been Tested?
- Manual testing of dropdown scroll behavior in the Git connect modal

Link to Devin run:
https://app.devin.ai/sessions/be239c326a7149eaaefe6f6c39d58470

## Automation

/test sanity

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/12710679010>
> Commit: 40cdbf4
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=12710679010&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Sanity`
> Spec:
> <hr>Fri, 10 Jan 2025 14:28:55 UTC
<!-- end of auto-generated comment: Cypress test results  -->

Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Co-authored-by: [email protected] <[email protected]>
  • Loading branch information
devin-ai-integration[bot] and mohanarpit authored Jan 10, 2025
1 parent 3d97706 commit 057c626
Showing 1 changed file with 6 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -291,7 +291,12 @@ function AddDeployKey({
Now, give write access to it.
</WellText>
<FieldContainer>
<StyledSelect onChange={setKeyType} size="sm" value={keyType}>
<StyledSelect
getPopupContainer={(triggerNode) => triggerNode.parentNode}
onChange={setKeyType}
size="sm"
value={keyType}
>
<Option value="ECDSA">ECDSA 256</Option>
<Option value="RSA">RSA 4096</Option>
</StyledSelect>
Expand Down

0 comments on commit 057c626

Please sign in to comment.