Merged
Conversation
stnguyen90
requested review from
TorstenDittmann,
abnegate,
christyjacob4 and
lohanidamodar
The extension is required by the SDK generator. Without it, the SDK generator
would throw an error like:
Class Normalizer not found
stnguyen90
force-pushed
the
feat-php-intl
branch
from
a571e71 to
0b47f3b
Compare
eldadfux
approved these changes
Mar 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The extension is required by the SDK generator. Without it, the SDK generator would throw an error like:
Test Plan
Manually installed the extension and then was able to run the SDK generator:
Related PRs and Issues
None
Have you read the Contributing Guidelines on issues?
Yes