Feat: new expandable table component #354
Conversation
…ron variant of accordian
|
PinkProject ID: Note Cursor pagination performs better than offset pagination when loading further pages. |
|
The preview deployment is ready. 🟢 Open Preview | Open Build Logs Last updated at: 2025-08-17 19:13:58 CET |
|
Uh oh! @HarshMN2345, the image you shared is missing helpful alt text. Check your pull request body. Alt text is an invisible description that helps screen readers describe images to blind or low-vision users. If you are using markdown to display images, add your alt text inside the brackets of the markdown image. Learn more about alt text at Basic writing and formatting syntax: images on GitHub Docs. |
🚀 Previews available on pkg.vc!📦
|
v2/pink-sb/src/lib/Accordion.svelte
Outdated
There was a problem hiding this comment.
why do we need to change Accordion here? Don't think its related to ExpandableTable directly.
There was a problem hiding this comment.
Considering its a Table, instead of the prop vars like rows & columns, I'd expect them to behave like Table's UI APIs like Table.Root, Table.Row, Table.Cell, etc. We can have something more flexible with default and expanded slots.
<!-- where root can track which item is opened -->
<ExpandableTable.Root let:root>
{#each columns as column (column.index)}
<ExpandableTable.Row {root} {...otherOptions}>
{Row title here}
<svelte:fragment slot="summary" {root}>
Show expanded content with details here.
</svelte:fragment>
</ExpandableTable.Row>
{/each}
</ExpandableTable.Root>cc @TorstenDittmann feel free to add comments if we should follow a different approach.
HarshMN2345
changed the title
|
Uh oh! @HarshMN2345, the image you shared is missing helpful alt text. Check your pull request body. Alt text is an invisible description that helps screen readers describe images to blind or low-vision users. If you are using markdown to display images, add your alt text inside the brackets of the markdown image. Learn more about alt text at Basic writing and formatting syntax: images on GitHub Docs. |
1 similar comment
|
Uh oh! @HarshMN2345, the image you shared is missing helpful alt text. Check your pull request body. Alt text is an invisible description that helps screen readers describe images to blind or low-vision users. If you are using markdown to display images, add your alt text inside the brackets of the markdown image. Learn more about alt text at Basic writing and formatting syntax: images on GitHub Docs. |
HarshMN2345
changed the title
|
Uh oh! @HarshMN2345, the image you shared is missing helpful alt text. Check your pull request body. Alt text is an invisible description that helps screen readers describe images to blind or low-vision users. If you are using markdown to display images, add your alt text inside the brackets of the markdown image. Learn more about alt text at Basic writing and formatting syntax: images on GitHub Docs. |
What does this PR do?
Introduces a new ExpandableTable component
Test Plan
Related PRs and Issues
(If this PR is related to any other PR or resolves any issue or related to any issue link all related PR and issues here.)
Have you read the Contributing Guidelines on issues?
yes