Skip to content

Conversation

ibaraki-douji
Copy link

@ibaraki-douji ibaraki-douji commented Aug 3, 2025

What does this PR do?

This is a work of the node versionning as only node runtime 14.5 followed the the node version.
All the others node runtimes versions are vXX.0 and the node version is NOT vXX.0 (for example runtime v20.0 is node v20.17 and not v20.0)

To resolve this i followed this pattern:

  • node-<major> : use the node:<major>-alpine image (may change to keep it as the latest major)
  • node-<major>.0 : use the node:<major>.0.0-alpine<alpVersion> (always include a first minor at 0)
  • node-<major>.<minor>: use the node:<major>.<minor>.<patch>-alpine<alpVersion> (can be created when new node images are created, should never change as thoses use the whole version with patches)

Test Plan

The runtimes tests where done through the open-runtimes/open-runtimes project.
I checked with files diff and multiple AIs to check if i didn't miss any versions in this project.

Related PRs and Issues

OpenRuntimes PR : open-runtimes/open-runtimes#413
Issues : open-runtimes/open-runtimes#412 and #89 as it will add the latest node 20/22/24

Additionnal Infos

Like i said in the openruntimes PR, i modeified the existing node runtimes to match the new pattern, tho it might break exiting project as the node version is lower than before (since before runtime v20.0 was node v20.17 now with the new pattern it will be node v20.0 for that runtime), if you prefer i can omit the changes on the existing runtimes to avoid breaking existing functions/sites.
And if i need to change it, please tell me if you would like me to rewrite the commits or just add a new commit that bring the old runtimes back.

Have you read the Contributing Guidelines on issues?

yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant