chore: regenerate sdks #75
Conversation
| @@ -9,7 +9,7 @@ class AppwriteException implements Exception { | |||
| /// for more information. | |||
| final String? type; | |||
| final int? code; | |||
| final dynamic response; | |||
| final String? response; | |||
There was a problem hiding this comment.
Changes here look good.
Would you also be able to update https://github.com/appwrite/appwrite/blob/1.6.x/docs/sdks/dart/CHANGELOG.md and get it deployed over in this repo?
| /// Get browser icon | ||
| /// |
There was a problem hiding this comment.
@abnegate why did we remove the 1st line comment from functions in dart?
There was a problem hiding this comment.
@abnegate said:
I think it caused issues when a single route defined multiple SDK methods. It seems redundant since it's always just the method name too.
with title
/** * Get account * * Get the currently authenticated users account */ function getAccount()vs without
/** * Get the currently authenticated users account */ function getAccount()
There was a problem hiding this comment.
At least in dart, the first line is supposed to be a one sentence summary.
https://dart.dev/effective-dart/documentation#do-start-doc-comments-with-a-single-sentence-summary
We can move forward with this, but we should see how this impacts the pub.dev API reference (e.g. https://pub.dev/documentation/dart_appwrite/latest/dart_appwrite/Account-class.html).
What does this PR do?
prepareRequest.dynamictostring(breaking)Test Plan
Related PRs and Issues
Have you read the Contributing Guidelines on issues?
Yes.