feat: add types to parameters #103
Merged
+287
−534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loks0n
reviewed
Mar 10, 2025
appwrite/client.py
Outdated
| @@ -13,11 +13,11 @@ def __init__(self): | |||
| self._endpoint = 'https://cloud.appwrite.io/v1' | |||
| self._global_headers = { | |||
| 'content-type': '', | |||
| 'user-agent' : 'AppwritePythonSDK/8.0.0 (${os.uname().sysname}; ${os.uname().version}; ${os.uname().machine})', | |||
| 'user-agent' : 'AppwritePythonSDK/9.0.0 (${os.uname().sysname}; ${os.uname().version}; ${os.uname().machine})', | |||
There was a problem hiding this comment.
Existing bug we need to fix, this should be an f-string it's not interpolating this 😬
loks0n
reviewed
Mar 10, 2025
Comment on lines
+11
to
+13
| result = health.get_queue_stats_usage_dump( | ||
| threshold = None # optional | ||
| ) |
There was a problem hiding this comment.
err should this endpoint be public?
There was a problem hiding this comment.
not really, but its part of the spec. In fact all the queue endpoints should be made hidden :/
ChiragAgg5k
approved these changes
Mar 10, 2025
loks0n
approved these changes
Mar 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #43
Test Plan
(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work.)
Related PRs and Issues
Have you read the Contributing Guidelines on issues?
(Write your answer here.)