Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update response types for python #1058

Merged
merged 3 commits into from
Mar 25, 2025
Merged

chore: update response types for python #1058

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0f16057
chore: add another space
ChiragAgg5k Mar 25, 2025
2d0d765
fix: return type for location
ChiragAgg5k Mar 25, 2025
c1a931e
fix: to use bytes
ChiragAgg5k Mar 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion templates/python/package/services/service.py.twig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,9 +28,10 @@ class {{ service.name | caseUcfirst }}(Service):
super({{ service.name | caseUcfirst }}, self).__init__(client)
{% for method in service.methods %}

def {{ method.name | caseSnake }}(self{% if method.parameters.all|length > 0 %}, {% endif %}{% for parameter in method.parameters.all %}{{ parameter.name | escapeKeyword | caseSnake }}: {{ parameter | getPropertyType(method) | raw }}{% if not parameter.required %} = None{% endif %}{% if not loop.last %}, {% endif %}{% endfor %}{% if 'multipart/form-data' in method.consumes %}, on_progress = None{% endif %}) -> {% if method.type == 'webAuth' %}str{% else %}Dict[str, Any]{% endif %}:
def {{ method.name | caseSnake }}(self{% if method.parameters.all|length > 0 %}, {% endif %}{% for parameter in method.parameters.all %}{{ parameter.name | escapeKeyword | caseSnake }}: {{ parameter | getPropertyType(method) | raw }}{% if not parameter.required %} = None{% endif %}{% if not loop.last %}, {% endif %}{% endfor %}{% if 'multipart/form-data' in method.consumes %}, on_progress = None{% endif %}) -> {% if method.type == 'webAuth' %}str{% elseif method.type == 'location' %}bytes{% else %}Dict[str, Any]{% endif %}:
"""
{% autoescape false %}{{ method.description | replace({"\n": "\n "}) }}{% endautoescape %}

{% if method.parameters.all|length > 0 or 'multipart/form-data' in method.consumes %}

Parameters
Expand All @@ -47,6 +48,8 @@ class {{ service.name | caseUcfirst }}(Service):
-------
{% if method.type == 'webAuth' %}str
Authentication response as a string
{% elseif method.type == 'location' %}bytes
Response as bytes
{% else %}Dict[str, Any]
API response as a dictionary
{% endif %}
Expand Down