-
Notifications
You must be signed in to change notification settings - Fork 273
Feat: Add Singapore (SGP) as available cloud region #2473
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
WalkthroughThis change updates Singapore across data and docs. In pins.ts, Singapore code is standardized from SIN to SGP and availability flags set (date fields replaced with available: true). Blog and docs pages are revised to mark Singapore as “Ready and operational/Available,” increasing edge locations from 4 to 5. The regions docs now include a live endpoint for Singapore: https://sgp.cloud.appwrite.io/v1. In RegionsMap.svelte, the city label is corrected from “Signapore” to “Singapore” and availability set to true. No exported/public APIs are modified. Possibly related PRs
Suggested reviewers
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (4)
static/images/docs/network/dark/edges-map.png
is excluded by!**/*.png
static/images/docs/network/dark/regions-map.png
is excluded by!**/*.png
static/images/docs/network/edges-map.png
is excluded by!**/*.png
static/images/docs/network/regions-map.png
is excluded by!**/*.png
📒 Files selected for processing (5)
src/lib/components/appwrite-network/data/pins.ts
(3 hunks)src/routes/blog/post/the-appwrite-network/+page.markdoc
(1 hunks)src/routes/docs/products/network/edges/+page.markdoc
(2 hunks)src/routes/docs/products/network/regions/+page.markdoc
(1 hunks)src/routes/products/functions/(components)/RegionsMap.svelte
(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: build
- GitHub Check: tests
🔇 Additional comments (7)
src/routes/blog/post/the-appwrite-network/+page.markdoc (1)
29-29
: LGTM!The Singapore region status update is consistent with the PR objective and matches the format of other available regions.
src/lib/components/appwrite-network/data/pins.ts (3)
487-492
: LGTM!Singapore PoP location correctly updated to use SGP code and marked as available.
580-585
: LGTM!Singapore edge location correctly updated to use SGP code and marked as available, replacing the previous date-based tracking.
645-650
: LGTM!Singapore region correctly updated to use SGP code and marked as available, replacing the previous date-based tracking.
src/routes/products/functions/(components)/RegionsMap.svelte (1)
95-97
: LGTM! Typo fix and availability update are correct.The city label typo "Signapore" has been corrected to "Singapore," and the region is now marked as available, consistent with the PR objectives to make Singapore (SGP) a live cloud region.
src/routes/docs/products/network/edges/+page.markdoc (2)
17-17
: LGTM! Edge count accurately updated.The edge network count correctly reflects the addition of Singapore as an available location, bringing the total from 4 to 5 active edge locations.
30-30
: LGTM! Singapore correctly marked as available.The status update from "2025" to "Available" is consistent with the PR objective and aligns with the format used for other active edge locations.
| Sydney | SYD | `https://syd.cloud.appwrite.io/v1` | Available | | ||
| San Francisco | SFO | `https://sfo.cloud.appwrite.io/v1` | Available | | ||
| Singapore | SGP | `coming soon` | Q4 2025 | | ||
| Singapore | SGP | `https://sgp.cloud.appwrite.io/v1` | Available | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
LGTM!
Singapore region documentation correctly updated with SGP code, live endpoint URL following the standard pattern, and Available status consistent with other files in this PR.
To confirm the endpoint is operational, you may verify its accessibility:
🏁 Script executed:
#!/bin/bash
# Description: Verify Singapore endpoint is accessible
curl -I https://sgp.cloud.appwrite.io/v1 2>&1 | head -5
Length of output: 447
Singapore endpoint returns HTTP 404
HEAD request to https://sgp.cloud.appwrite.io/v1 returned HTTP/2 404. Confirm the service is deployed and responding or update the documentation accordingly.
🤖 Prompt for AI Agents
In src/routes/docs/products/network/regions/+page.markdoc around line 26, the
Singapore endpoint listed (https://sgp.cloud.appwrite.io/v1) returns HTTP 404;
verify whether the service is actually deployed and responding at that URL, and
then either update the document to the correct working endpoint or change the
availability column to reflect the endpoint is unavailable; ensure the URL is
tested with a HEAD/GET request and the doc entry is edited to show the accurate
endpoint or status.
What does this PR do?
Make Singapore (SGP) cloud region available
Test Plan
Related PRs and Issues
(If this PR is related to any other PR or resolves any issue or related to any issue link all related PR and issues here.)
Have you read the Contributing Guidelines on issues?
yes
Summary by CodeRabbit